Remove dead code in R2RPEBuilder#115953
Merged
elinor-fung merged 1 commit intodotnet:mainfrom May 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unused code from R2RPEBuilder to simplify section relocation logic.
- Deletes the
SectionRVADeltastruct and its list field - Removes
RelocateRVAandRelocateDirectoryEntrymethods - Drops the
SDataSectionNameconstant and related dead comments
elinor-fung
commented
May 23, 2025
| _sectionBuilder.SetDllNameForExportDirectoryTable(outputFileSimpleName); | ||
| } | ||
|
|
||
| if (_sectionBuilder.FindSection(R2RPEBuilder.RelocSectionName) == null) |
Member
Author
There was a problem hiding this comment.
We create the section builder and add any sections above - there's no need to check if the reloc section already exists.
jkotas
approved these changes
May 24, 2025
Open
3 tasks
Copilot AI
added a commit
that referenced
this pull request
Feb 12, 2026
…with empty SafeArray type name When a MarshalAs blob contains NATIVE_TYPE_SAFEARRAY with a zero-length user-defined type name, the native GetMarshalAs returned a non-null pointer despite having zero bytes. The managed code then used CreateReadOnlySpanFromNullTerminated to decode this pointer, reading past the blob into garbage memory, producing a garbled string that failed type resolution with TypeLoadException. Fix: Return NULL from native code when byte count is 0 for safeArrayUserDefinedSubType, marshalType, and marshalCookie. Also add try/catch around safeArrayUserDefinedType resolution for defense-in-depth, matching the existing pattern for marshalTypeRef. Fixes #115953 Co-authored-by: stephentoub <2642209+stephentoub@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.