Merged
Conversation
github-actions
bot
added
the
needs-area-label
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a minidump generation issue by wrapping IL version method calls with a try-catch block to ensure that an exception in GetIL doesn’t prevent dumping a full callstack.
- Wraps GetIL and related ILCodeVersion calls in an exception block
- Uses EX_CATCH_RETHROW_ONLY_COR_E_OPERATIONCANCELLED to selectively rethrow only specific exceptions
tommcdon
approved these changes
May 14, 2025
thaystg
added
area-Diagnostics-coreclr
and removed
needs-area-label
Contributor
|
Tagging subscribers to this area: @tommcdon |
Member
Author
|
/backport to release/9.0-staging |
Member
Author
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/15121700431 |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/15121702986 |
This was referenced May 19, 2025
tommcdon
pushed a commit
to tommcdon/runtime
that referenced
this pull request
May 28, 2025
This PR addresses a minidump generation issue by wrapping IL version method calls with a try-catch block to ensure that an exception in GetIL doesn’t prevent dumping a full callstack. Wraps GetIL and related ILCodeVersion calls in an exception block Uses EX_CATCH_RETHROW_ONLY_COR_E_OPERATIONCANCELLED to selectively rethrow only specific exceptions
tommcdon
pushed a commit
to tommcdon/runtime
that referenced
this pull request
May 28, 2025
This PR addresses a minidump generation issue by wrapping IL version method calls with a try-catch block to ensure that an exception in GetIL doesn’t prevent dumping a full callstack. Wraps GetIL and related ILCodeVersion calls in an exception block Uses EX_CATCH_RETHROW_ONLY_COR_E_OPERATIONCANCELLED to selectively rethrow only specific exceptions
This was referenced May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When it's generating a minidump a failure was happening while calling ilVersion.GetIL(); then we are skipping saving all the rest of the information needed to run successfully the !clrstack command.
As we have others try catches in the code I thought that it's not a problem to add another one, then we will not save the IL correctly because the GetIL will throw an exception in a specific function but the minidump will be useful with a full callstack.