Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the IDN tests on Linux by updating test file references and adjusting ICU version branching to correctly map to the appropriate Unicode IDNA test data.
- Updated documentation in Unicode_15_1_IdnaTest.cs to reference the correct test data file.
- Added a new Unicode_15_0_IdnaTest.cs test file.
- Updated Factory.cs to adjust ICU version comparisons for proper test file selection.
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Unicode_15_1_IdnaTest.cs | Updated comment reference to point to the Unicode 15.1 test data file. |
| Unicode_15_0_IdnaTest.cs | Added new test file for Unicode 15.0. |
| ReadMe.txt | Added documentation for Unicode 15.0 test data. |
| Factory.cs | Modified version checks to map ICU versions to the correct IDNA test data files and test class. |
Files not reviewed (2)
- src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/NlsTests/System.Globalization.Extensions.Nls.Tests.csproj: Language not supported
- src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/System.Globalization.Extensions.Tests.csproj: Language not supported
Comments suppressed due to low confidence (2)
src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs:34
- Ensure that the branching logic for ICUVersion using Version(72, 1, 0, 4) is adequately covered by tests, especially around the boundary conditions distinguishing between Unicode 15.1 and 15.0 test file selections.
else if (PlatformDetection.ICUVersion >= new Version(72, 1, 0, 4))
src/libraries/System.Runtime/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Factory.cs:75
- Verify that the conditional branch for returning a Unicode_15_1_IdnaTest is covered by unit tests, particularly when ICUVersion is exactly Version(72, 1, 0, 4).
else if (PlatformDetection.ICUVersion >= new Version(72, 1, 0, 4))
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-globalization |
Member
Author
carlossanlop
approved these changes
Apr 28, 2025
...e/tests/System.Globalization.Extensions.Tests/IdnMapping/Data/Unicode_15_0/IdnaTest_15_0.txt
Show resolved
Hide resolved
Contributor
|
/azp run runtime-coreclr libraries-jitstress |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ericstj
approved these changes
Apr 28, 2025
This was referenced Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #115087