Strip trailing slash from source dir for cmake4#114779
Merged
akoeplinger merged 4 commits intodotnet:mainfrom Apr 18, 2025
Merged
Strip trailing slash from source dir for cmake4#114779akoeplinger merged 4 commits intodotnet:mainfrom
akoeplinger merged 4 commits intodotnet:mainfrom
Conversation
ghost
added
the
dotnet-policy-service
bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
Member
|
why was the existing code to remove the trailing slash not working? |
Member
Author
|
It was not self-assigning |
Member
|
ah ok got it but I think that might've been a copy/paste mistake, I don't think it should assign __ProjectDir, just strip the trailing slash from __sourceDir |
akoeplinger
approved these changes
Apr 17, 2025
am11
commented
Apr 17, 2025
jkoritzinsky
approved these changes
Apr 17, 2025
This was referenced Apr 17, 2025
Open
Member
|
/ba-g failures are not related to the change |
Member
|
/backport to release/9.0-staging |
Contributor
|
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/14593733890 |
Member
|
/backport to release/8.0-staging |
Contributor
|
Started backporting to release/8.0-staging: https://github.com/dotnet/runtime/actions/runs/14593740104 |
This was referenced Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative fix for #114766.