[release/9.0-staging] JIT: avoid fp divide by zero in profile synthesis#113418
Merged
jeffschwMSFT merged 1 commit intorelease/9.0-stagingfrom Mar 26, 2025
Merged
Conversation
This can trip up users that have enabled floating point exceptions. While we don't generally support changing the exception modes we also can easily avoid dividing by zero here. Addresses #113369
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
|
@jeffschwMSFT @JulieLeeMSFT FYI cc @dotnet/jit-contrib |
amanasifkhalid
approved these changes
Mar 12, 2025
jeffschwMSFT
approved these changes
Mar 12, 2025
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
jeffschwMSFT
added
the
Servicing-consider
JulieLeeMSFT
approved these changes
Mar 12, 2025
leecow
added
Servicing-approved
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #113396 to release/9.0-staging
/cc @AndyAyersMS
Customer Impact
Unexpected floating-point divide by zero exception. While we generally don't support running managed code with FP exceptions enabled, we also should not be generating such exceptions needlessly.
There is precedent for us back porting this kind of change, see eg: #76334
Regression
.NET 9 added a fair amount of FP processing to the JIT that wasn't there in .NET 8.
Testing
Verified the JIT will no longer cause FP exception from this computation.
Risk
Low, no diffs in SPMI.