[release/9.0-staging] Fix hostfxr.h to be valid C again.#110060
Merged
elinor-fung merged 3 commits intorelease/9.0-stagingfrom Nov 28, 2024
Merged
[release/9.0-staging] Fix hostfxr.h to be valid C again.#110060elinor-fung merged 3 commits intorelease/9.0-stagingfrom
elinor-fung merged 3 commits intorelease/9.0-stagingfrom
Conversation
ghost
added
the
jeffschwMSFT
approved these changes
Nov 21, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. please get a code review. we will take for consideration in 9.0.x
elinor-fung
approved these changes
Nov 21, 2024
AaronRobinsonMSFT
approved these changes
Nov 21, 2024
This was referenced Nov 21, 2024
jeffschwMSFT
added
Servicing-approved
am11
reviewed
Nov 26, 2024
danmoseley
reviewed
Nov 26, 2024
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| // hostfxr.h is a public API. When included in .c files, it may fail to compile |
Member
There was a problem hiding this comment.
sounded like there might be one or two other headers that could benefit from similar protection?
Member
There was a problem hiding this comment.
Absolutely! The three documented headers: https://learn.microsoft.com/en-us/dotnet/core/tutorials/netcore-hosting
#include <nethost.h>
#include <coreclr_delegates.h>
#include <hostfxr.h>
I'll fix it in main.
Open
3 tasks
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #109763 to release/9.0-staging
/cc @elinor-fung @alexrp
Customer Impact
hostfxr.hprovided for customers doing custom hosting is not valid C, so consumers in C cannot not use the latest version.Regression
Regressed in 9.0 with #101451.
Testing
Manual.
Risk
Low. The change just adds the
structkeyword for a function parameter such that the header is valid C again.