[release/9.0-staging] Fix handling of IDynamicInterfaceCastable wrt CastCache#110007
Merged
jeffschwMSFT merged 2 commits intorelease/9.0-stagingfrom Jan 8, 2025
Merged
Conversation
Fixes #108229. The actual fix is the addition of an `if` check where it originally wasn't. I also fixed the other checks for consistency - positive checks are fine to cache, and negative checks against non-interface targets are also fine to cache.
ghost
added
the
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
jkotas
approved these changes
Nov 20, 2024
jeffschwMSFT
approved these changes
Nov 21, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we are holding on this one but may take with the other IDynamicInterfaceCastable issues for consideration
This was referenced Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #108328 to release/9.0-staging
/cc @MichalStrehovsky
Customer Impact
One more IDynamicInterfaceCastable related issue. This one was found as we were unblocking tests as part of fixing a customer reported issue (that was known and had known disabled tests). The tests happened to also hit this problem.
The issue is that a cast of a IDynamicInterfaceCastable object to a variant interface would store the wrong value into CastCache - we'd answer the first cast correctly, but a second time the same pair of type is checked for castability, we'd use the wrong cached value and invalid cast exception would happen.
Regression
Regressed in .NET 8, likely in #90234.
Testing
Added targeted test that is part of this PR. We also subsequently enabled more testing in #108376 but that depends on both PRs so it's in a separate PR.
Risk
This should be low risk, it only affects IDynamicInterfaceCastable and we made sure the caching logic is same as CoreCLR. This has been in main for 2 months.
IMPORTANT: If this backport is for a servicing release, please verify that:
The PR target branch is
release/X.0-staging, notrelease/X.0.If the change touches code that ships in a NuGet package, you have added the necessary package authoring and gotten it explicitly reviewed.