[release/9.0-staging] Ensure Vector.Create is properly recognized as intrinsic#109322
Merged
tannergooding merged 2 commits intorelease/9.0-stagingfrom Dec 4, 2024
Merged
Conversation
ghost
added
the
area-CodeGen-coreclr
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Member
|
CC. @dotnet/jit-contrib, @BruceForstall for review @JulieLeeMSFT this should be considered for backport since its a perf regression in one of the intrinsic APIs, which are expected to be accelerated, and a user reported the initial regression |
BruceForstall
approved these changes
Oct 29, 2024
Member
|
CC. @JulieLeeMSFT, I think this is just pending management approval for backport now. |
jeffschwMSFT
approved these changes
Dec 2, 2024
Member
jeffschwMSFT
left a comment
jeffschwMSFT
left a comment
There was a problem hiding this comment.
lgtm. we will take for consideration in 9.0.x
tannergooding
added
Servicing-approved
Member
|
Approved by tactics over e-mail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #108945 to release/9.0-staging
/cc @tannergooding
Customer Impact
#108929
Customers using
System.Numerics.Vector<T>may see unexpected perf slowdowns on .NET 9 due to thenew Vector(T scalar)APIs no longer being recognized as[Intrinsic]and therefore not being accelerated by the JIT.Regression
Vector<T>is one of the original hardware accelerated types introduced in 2014 for .NET Framework. There have been multiple iterations over the past several releases modernizing the JIT implementation to bring it inline with the newer types exposed by theSystem.Runtime.Intrinsicsnamespace.The regression was introduced in .NET 9 as part of one of the larger refactorings done for the
System.Numerics.Vector<T>types when theVector.Create<T>(T scalar)APIs were added for parity and the existing constructors were meant to defer to these APIs.Testing
JIT disassembly was checked to ensure it was generated the expected output.
Risk
Low. This is a lowlevel performance oriented API. The regression is one of performance and not of correctness.
The fix is simply ensuring the existing logic is correctly hooked up to the new APIs as was intended.