Include Microsoft.Common.Test.targets in Arm64#9984
Merged
rainersigwald merged 1 commit intodotnet:mainfrom Apr 15, 2024
Merged
Include Microsoft.Common.Test.targets in Arm64#9984rainersigwald merged 1 commit intodotnet:mainfrom
rainersigwald merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Hello @dfederm, I noticed that you’re changing an .swr file or any file under src/Package/MSBuild.VSSetup.. Please make sure to validate this change by an experimental VS insertion. This is accomplished by pushing to an exp/* branch, which requires write permissions to this repo. |
rainersigwald
approved these changes
Apr 9, 2024
Member
rainersigwald
left a comment
There was a problem hiding this comment.
This is fine and is what I did for other arches in #9547. I think we should consider changing the import to be $(MSBuildToolsPath32) but let's take this for now.
JanKrivanek
approved these changes
Apr 10, 2024
AR-May
approved these changes
Apr 15, 2024
Member
|
/backport to vs17.10 |
Contributor
|
Started backporting to vs17.10: https://github.com/dotnet/msbuild/actions/runs/8711422953 |
1 task
This was referenced Jul 28, 2025
Closed
Closed
This was referenced Aug 4, 2025
Closed
Closed
This was referenced Aug 15, 2025
This was referenced Nov 24, 2025
Closed
This was referenced Dec 2, 2025
This was referenced Dec 9, 2025
Open
This was referenced Dec 24, 2025
This was referenced Feb 9, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This file is missing, leading to errors in the Arm64 flavor of VS
See: https://developercommunity.visualstudio.com/t/Arm64-Unable-to-use-MicrosoftBuildRu/10632924?ref=native&refTime=1712530347328&refUserId=ba1eecbf-9f1b-431b-ba02-0503abd8762c