Added task assembly location to TaskStartedEventArgs#9948
Added task assembly location to TaskStartedEventArgs#9948MichalPavlik merged 20 commits intomainfrom
Conversation
|
@ladipro, is this comment still valid? I would remove the interface as part of this PR |
|
The interface is internal and has only one internal implementation. So it looks like the comment is still valid. |
|
I had same opinion, but I wanted to check if there is a plan to implement additional execution host(s)... for whatever reason :) |
ladipro
left a comment
There was a problem hiding this comment.
I've left a couple of inline comments.
There was a problem hiding this comment.
Overall looks good.
I'd want the BuildEventArgsReader to be backwards compatible before I signoff.
Plus don't forget to update the same class in Viewer repo as well (or create task in viewer repo for that)
Having the diverging assembly path logging handled here or tracking item created would be nice as well.
src/Build/BackEnd/Components/Logging/LoggingServiceLogMethods.cs
Outdated
Show resolved
Hide resolved
src/Build/BackEnd/Components/Logging/LoggingServiceLogMethods.cs
Outdated
Show resolved
Hide resolved
@JanKrivanek, I created tracking issue for the viewer: KirillOsenkov/MSBuildStructuredLog#771 |
|
I think we need the viewer support ready and merged first, then merge this PR. |
Fixes #9290
Context
TaskStartedEventArgs now contains AssemblyName of the assembly that implements the task.
Changes Made
Adding full assembly name to event and propagating the value from upper layers.
ITaskExecutionHostinterface was removed.Testing
Manual testing for setting the value. Unit test for serialization
Notes