Conversation
rokonec
previously requested changes
Mar 15, 2024
JanKrivanek
approved these changes
Mar 27, 2024
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good - after the cref for ProjectRootElement.MarkDirty is removed.
Thanks!
This was referenced Jul 28, 2025
Closed
Closed
This was referenced Aug 4, 2025
Closed
Closed
This was referenced Aug 15, 2025
This was referenced Nov 23, 2025
Closed
This was referenced Dec 1, 2025
This was referenced Dec 9, 2025
Open
This was referenced Dec 24, 2025
This was referenced Feb 9, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9766
Context
There are some documentation issues we should fix: dotnet/msbuild-api-docs#39 (comment)
msbuild-api-docs/xml/Microsoft.Build.Construction/ProjectRootElement.xml
Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Microsoft.Build.Construction.ProjectRootElement.MarkDirty(System.String,System.String)'.
msbuild-api-docs/xml/Microsoft.Build.Framework.XamlTypes/BaseProperty.xml
Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'seealso' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
msbuild-api-docs/xml/Microsoft.Build.Framework/BuildEventArgs.xml
Line 0, Column 0: [Warning: xref-not-found - See documentation] Cross reference not found: 'Microsoft.Build.Framework.BuildEventArgs.timestamp'.
msbuild-api-docs/xml/Microsoft.Build.Framework/CustomBuildEventArgs.xml
Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Line 0, Column 0: [Warning: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.
Changes Made
Update the link