Add FileAccessData Id and CorrelationId#9615
Merged
JanKrivanek merged 4 commits intodotnet:vs17.9from Jan 18, 2024
Merged
Conversation
|
Hello! I noticed that you're targeting one of our servicing branches. Please consider updating the version. |
rokonec
approved these changes
Jan 11, 2024
Co-authored-by: Rainer Sigwald <raines@microsoft.com>
JanKrivanek
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9616
Summary
This passes through 2 more fields from BuildXL to the project cache plugins.
MSBuildCache needs this information to do some copy tracing optimizations.
Customer Impact
Without this change, MSBuild Cache plug-ins will not be able to correlate copy source and destination events, which will prevent it from making some optimizations based on the knowledge for the specific ways files are accessed in the builds. This blocks the proposed optimizations in MSBuildCache, which is part of onboarding PowerToys and Terminal repos to use the MSBuild Cache.
Regression?
No
Testing
Manually tested that the new fields are being exposed to the plugins.
Risk
Low. This is an experimental feature and the change is additive.