Fix Arcade's BeforeCommon imports not being respected#9555
Merged
JanKrivanek merged 3 commits intomainfrom Jan 3, 2024
Merged
Conversation
MSBuild's build ifnrastructure overwrites the `CustomBeforeMicrosoftCommonTargets` property which results in Arcade's entry to get dropped. Arcade adds to that property to import common files.
mmitche
approved these changes
Dec 15, 2023
rainersigwald
approved these changes
Dec 15, 2023
ViktorHofer
changed the title
Member
Author
|
Oh wow. I'm not sure how this change could introduce new prebuilts. cc @dotnet/source-build-contrib |
Member
|
Okay this change got a lot scarier! |
Member
|
This change appears to be causing StringTools.Benchmark.csproj to be restored but it wasn't prior to these changes. |
Member
|
Here's what the binlogs show. Prior to these changesWith these changesNote that this comes from different restore tasks. In the first, it uses |
Member
Author
|
This seems to be related to #7058. I can reproduce this locally as well. Static graph restore doesn't respect slnf files. |
Member
Author
|
I can reproduce this in a sample application. Filed a nuget issue for it: NuGet/Home#13097 Updated my PR not change the restore engine when building from source. |
rainersigwald
approved these changes
Dec 15, 2023
Member
Author
|
This should be ready to be merged in and fixes an issue with msbuild's Arcade integration. |
JanKrivanek
approved these changes
Jan 3, 2024
This was referenced Jul 29, 2025
Closed
Closed
This was referenced Oct 15, 2025
This was referenced Nov 13, 2025
Closed
Open
This was referenced Nov 22, 2025
This was referenced Dec 1, 2025
This was referenced Dec 9, 2025
Open
This was referenced Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSBuild's build ifnrastructure overwrites the
CustomBeforeMicrosoftCommonTargetsproperty which results in Arcade's entry to get dropped.Arcade adds to that property to import common files.
This fixes static graph restore not working in this repository when using Arcade's
ExcludeFromBuildproperties.