Change Version switch output to finish with a newline#9485
Change Version switch output to finish with a newline#9485f-alizada merged 4 commits intodotnet:vs17.9from
Conversation
rainersigwald
left a comment
There was a problem hiding this comment.
This could, conceivably, break someone who has a script that's calling msbuild -nologo -version | script_that_cant_handle_newline, right? I hate that I'm so conservative but I think I want it behind a changewave.
|
Yes, that's conceivable. And for someone who has written code like that and hits this change, the defect would be mysterious. |
|
I think I should change the |
|
That sounds fine to me. |
|
Should this be in a change wave and should it be change wave 17.10? |
|
Yes and yes, please. |
f-alizada
left a comment
There was a problem hiding this comment.
Thank you for the PR!
I left one comment with question about the verification of two scenarios in one test, overall looks good :)
f-alizada
left a comment
There was a problem hiding this comment.
Thank you for the updates! Left one comment regarding the base branch to be merged
930db94 to
2a8e760
Compare
Fixes #9482
Context
The -version switch doesn't terminate its output with a newline which some shells don't like.
Changes Made
ShowVersion().Testing
Tested on Windows 10 and macOS 14.
Tested by running the full unit test suite and by manually running the
-versionswitch under cmd (Windows), pwsh (Windows and macOS), and zsh (macOS).