Change Copy task LogDiagnostics Warning so it is suppressible#9217
Merged
rainersigwald merged 3 commits intodotnet:mainfrom Sep 21, 2023
Merged
Conversation
JanKrivanek
approved these changes
Sep 13, 2023
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Please remove/alter the existing comment (it's confusing now) - than I'm OK with change. As soon as the MessageImportance.High was considered and there are reasons not to use it.
b320586 to
caf06d1
Compare
Member
Author
|
Not closed actually, but hard reset + force push have confused github |
JanKrivanek
suggested changes
Sep 14, 2023
Member
JanKrivanek
left a comment
There was a problem hiding this comment.
Looks good!
We just need to pick unique error codes
JanKrivanek
approved these changes
Sep 14, 2023
rainersigwald
approved these changes
Sep 14, 2023
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Sep 27, 2023
These strings were introduced in dotnet#9217 but caused loc breaks. Fixes dotnet#9283.
rainersigwald
added a commit
that referenced
this pull request
Sep 27, 2023
bulatgrzegorz
pushed a commit
to bulatgrzegorz/selective-condition-evaluator
that referenced
this pull request
Oct 16, 2023
These strings were introduced in dotnet#9217 but caused loc breaks. Fixes dotnet#9283.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9210
Context
Copy task implement
LogDiagnosticsas warnings. This is causing issues for/WarnAsErroruse cases.Changes Made
Change Copy task
LogDiagnosticsfrom Warning to low importance Message.The reasoning for Warning level "so it's easily visible" is, IMO, not strong enough.
Testing
Unit tests.
Locally.
Notes
@rainersigwald Since we see increasing number of people reporting issues with Copy conflicts, I believe it is candidate for 17.8