Override SkipApplyOptimizationData to true when disabling OptProf data collection#12106
Merged
GangWang01 merged 2 commits intodotnet:vs17.11from Jul 4, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that when OptProf data collection is disabled, the build pipeline skips applying optimization data.
- Adds a conditional variable
SkipApplyOptimizationDataset to true ifEnableOptProfis false - Includes an explanatory comment for the new conditional
Comments suppressed due to low confidence (1)
.vsts-dotnet.yml:41
- The new conditional branch for overriding SkipApplyOptimizationData isn't covered by existing pipeline tests. Consider adding a test to verify that SkipApplyOptimizationData is set to true when EnableOptProf is false.
- ${{ if eq(parameters.EnableOptProf, false) }}:
YuliiaKovalova
approved these changes
Jul 3, 2025
SimaTian
approved these changes
Jul 3, 2025
This was referenced Feb 4, 2026
Closed
This was referenced Feb 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When disabling OptProf data collection, build should skip apply optimization data.