Fix insertion target branches and schedule#11909
Merged
JanProvaznik merged 1 commit intodotnet:vs17.14from May 27, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the insertion branch and scheduling logic for VS insertions and bumps the tooling version.
- Bumps the VersionPrefix to 17.14.11 in
eng/Versions.props. - Enables and configures the daily main schedule in
vs-insertion.ymland updates theAutoInsertTargetBranchforvs17.14. - Removes the now-unused experimental schedule block from
vs-insertion-experimental.yml.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| eng/Versions.props | Bumped VersionPrefix from 17.14.10 to 17.14.11 |
| azure-pipelines/vs-insertion.yml | Enabled daily main schedule; changed AutoInsertTargetBranch for vs17.14 |
| azure-pipelines/vs-insertion-experimental.yml | Removed the experimental scheduling block |
Comments suppressed due to low confidence (1)
azure-pipelines/vs-insertion-experimental.yml:4
- [nitpick] The commented experimental schedule block is no longer needed; consider removing these lines to reduce clutter.
-# Since our release branch is the one flowing into main
YuliiaKovalova
approved these changes
May 26, 2025
Member
Author
|
Actually it was fixed in main but not in 17.14 :( so that's the only meaningful change (the rest is just so that the code is consistent between branches) |
surayya-MS
approved these changes
May 27, 2025
This was referenced Feb 4, 2026
Closed
This was referenced Feb 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
we should be inserting 17.14 to 17.14 & the schedule should be set for main normal insertion not the experimental one
Changes Made
Pseudo-reverts #11558
Notes
should be merged forward to main