using virtual fuction instead of reflection#11513
Merged
Conversation
Member
JanProvaznik
left a comment
There was a problem hiding this comment.
could you please measure impact in perfstar?
Member
Author
|
I've set up a perf star run. It seems that this has a measurable impact for evaluation performance: |
JanProvaznik
approved these changes
Mar 12, 2025
MichalPavlik
approved these changes
Mar 13, 2025
This was referenced Jul 28, 2025
This was referenced Aug 4, 2025
This was referenced Dec 28, 2025
This was referenced Jan 5, 2026
This was referenced Jan 12, 2026
This was referenced Jan 26, 2026
This was referenced Feb 4, 2026
Closed
This was referenced Feb 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
###Part of #11160
Building on top of Eric's IPC pr - his work allowed for other bottlenecks to reveal themselves.
Context
Currently, the ReadFromStream function uses
for a large portion of it's packet deserialization. This is large enough to be seen in the performance profiler as shown above more than 3% of CPU an it's on a critical path.
When I checked, the function was already virtual so the change is minimal. Unfortunately I had to make an allowance to the task host since it wasn't compatible.
Changes Made
Exposed a convenience public endpoint for the CreateFromStream function, that calls the virtual method Create from stream.
Used this endpoint instead of delegate creation.
Testing
As long as nothing breaks, I consider that a win.
I did local profiling.