Skip to content

Revert "Permit throwaway parameters (#10209)"#10436

Merged
rainersigwald merged 1 commit intodotnet:mainfrom
rainersigwald:revert-#10209
Jul 23, 2024
Merged

Revert "Permit throwaway parameters (#10209)"#10436
rainersigwald merged 1 commit intodotnet:mainfrom
rainersigwald:revert-#10209

Conversation

@rainersigwald
Copy link
Member

This reverts commit 9f69926, to fix #10435.

@rainersigwald
Copy link
Member Author

This was a clean revert except for the XLF files which I reverted, built, and checked that back in.

Copy link
Contributor

@Forgind Forgind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😭

@rainersigwald rainersigwald enabled auto-merge (squash) July 23, 2024 21:18
@rainersigwald
Copy link
Member Author

Merging on red due to urgency; failure was CanceledTasksDoNotLogMSB4181

Shouldly.ShouldAssertException : isSubmissionComplated\r\n    should be\r\nTrue\r\n    but was\r\nFalse\r\n\r\nAdditional Info:\r\n    Waiting for that the build submission is completed failed in the timeout period 2000 ms.

   at Microsoft.Build.UnitTests.BackEnd.TaskBuilder_Tests.CanceledTasksDoNotLogMSB4181() in D:\a\1\s\src\Build.UnitTests\BackEnd\TaskBuilder_Tests.cs:line 190
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

@rainersigwald rainersigwald disabled auto-merge July 23, 2024 21:42
@rainersigwald rainersigwald merged commit cec6676 into dotnet:main Jul 23, 2024
@rainersigwald rainersigwald deleted the revert-#10209 branch July 23, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Property functions with a single _ as an argument return bad results

3 participants