Solution doesn't respect WarningsNotAsErrors

[rainersigwald]

The promotion of the "plain property" version of some warning-related settings:

msbuild/src/Tasks/Microsoft.Common.CurrentVersion.targets

Lines 668 to 672 in 69b3e7a

	<PropertyGroup>
	<MSBuildWarningsAsMessages Condition="'$(MSBuildWarningsAsMessages)'==''">$(NoWarn)</MSBuildWarningsAsMessages>
	<MSBuildWarningsAsErrors Condition="'$(MSBuildWarningsAsErrors)'==''">$(WarningsAsErrors)</MSBuildWarningsAsErrors>
	<MSBuildWarningsNotAsErrors Condition="'$(MSBuildWarningsNotAsErrors)'==''">$(WarningsNotAsErrors)</MSBuildWarningsNotAsErrors>
	</PropertyGroup>

Is in Microsoft.Common.CurrentVersion.targets, which is not imported into solution metaprojects. This means that any warnings raised in the solution itself (like in NuGet operations) may be promoted to error even if $(WarningsNotAsErrors) includes them.

This is very related to #10873 and we should consider fixing both by looking at the unprefixed versions in the engine (if the prefixed version is unset) rather than requiring XML logic to do it.

[ViktorHofer]

@SimaTian I assume this should get re-opened given that #10942 got reverted later?