[tests] Update max simulator OS version.#24867
Conversation
This fixes the following problem: * We default the max simulator version to the SDK version of an OS (currently 26.2) * However, iOS/tvOS 26.3 exists, and that's the simulator 'xcodebuild -downloadPlatform' installs with Xcode 26.3. * The max simulator version is what we use in xharness to decide which simulator to run tests in. * The result is that xharness will try to use/create a simulator for iOS 26.2, but that might not be possible (unless said simulator was already installed from before the current build), because it wasn't provisioned.
There was a problem hiding this comment.
Pull request overview
Updates simulator test OS selection so xharness uses the newest simulator runtime available with the selected Xcode (even when the SDK version hasn’t changed), avoiding attempts to create/run simulators for unprovisioned OS versions.
Changes:
- Introduce logic in
Make.configto setMAX_IOS_SIMULATOR_VERSION/MAX_TVOS_SIMULATOR_VERSIONbased onXCODE_VERSION(special-casing Xcode 26.3 -> simulator 26.3). - Add make-time guardrails (
$(error ...)) to force revisiting this mapping when Xcode/SDK version relationships change.
You can also share your feedback on Copilot code review. Take the survey.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… iOS/tvOS 26.3 Replace xamvideotest.mp4 with a freshly-generated, well-formed H.264 Baseline video. The old video (created in 2015 by Mainconcept encoder) had non-standard dimensions (438x434, not multiples of 16) and produced codecBadDataErr (-8969) on iOS/tvOS 26.4 simulators where the decoder is stricter. The new video uses standard dimensions (320x240), H.264 Constrained Baseline profile, and is generated with ffmpeg to ensure well-formed NAL units. Also add WaitForAsynchronousFrames() after FinishDelayedFrames() in all async decode tests. FinishDelayedFrames() directs the session to emit all delayed frames, but WaitForAsynchronousFrames() is needed to block until all async callbacks have completed before checking assertions. Fixes #24844 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #c663b9f] Build passed (Build packages) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #1fbf9e6] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #1fbf9e6] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #1fbf9e6] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This fixes the following problem: