Small updates to help with linker->aot port #2873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
am11
reviewed
Jun 30, 2022
src/ILLink.Shared/DiagnosticId.cs
Outdated
| _ => MessageSubCategory.None, | ||
| }; | ||
|
|
||
| public static string GetDiagnosticCategory (this DiagnosticId diagnosticId) |
Member
There was a problem hiding this comment.
nit: this can be reduced to:
public static string GetDiagnosticCategory (this DiagnosticId diagnosticId) => (int)diagnosticId switch
{
> 2000 and < 3000 => DiagnosticCategory.Trimming,
>= 3000 and < 3050 => DiagnosticCategory.SingleFile,
>= 3050 and <= 6000 => DiagnosticCategory.AOT,
_ => throw new ArgumentException ($"The provided diagnostic id '{diagnosticId}' does not fall into the range of supported warning codes 2001 to 6000 (inclusive).")
};
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
* Move GetDiagnosticCategory into shared code * Describe the intent around usage of DiagnosticContext in a comment * Minor fix in MessageOrigin GetHasCode * Add tests for patterns which NativeAOT had trouble with Linker changes made for #71485 Commit migrated from dotnet/linker@e4d8575
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linker changes made for dotnet/runtime#71485