Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a syntax error in the Azure DevOps pipeline configuration where a parameter reference in a condition was missing the required ${{ }} compile-time expression syntax. This issue was preventing the runTests parameter from being properly evaluated in the codecoverage stage condition.
Key Changes:
- Added
${{ }}wrapper aroundeq(parameters.runTests, true)in the codecoverage stage condition to enable proper compile-time parameter evaluation
ericstj
reviewed
Dec 20, 2025
ericstj
approved these changes
Dec 20, 2025
Member
ericstj
left a comment
ericstj
left a comment
There was a problem hiding this comment.
Thanks for fixing, that will teach me to trust copilot on things not validated in CI
Member
Author
|
Sure thing; thanks for the review, @ericstj. |
This was referenced Jan 13, 2026
Merged
Bump Microsoft.Extensions.Http.Resilience from 10.1.0 to 10.2.0
askpt/openfeature-dotnet-workshop#96
Closed
Closed
Merged
Merged
This was referenced Jan 19, 2026
Bump Microsoft.Extensions.AI.Abstractions from 10.1.1 to 10.2.0
modelcontextprotocol/csharp-sdk#1163
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced by Skip tests by default in internal rolling builds (#7151)
Using parameters within a condition requires
${{ }}evaluation. https://learn.microsoft.com/en-us/azure/devops/pipelines/process/conditions?view=azure-devops#parameters-in-conditionsThis fix was validated by triggering a run against this branch.
Microsoft Reviewers: Open in CodeFlow