-
Notifications
You must be signed in to change notification settings - Fork 850
Fix typo in AddExtendedLoggerFactory method name #6883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR corrects a typo in the method name AddExtendedLoggerFeactory to AddExtendedLoggerFactory throughout the codebase. The typo was in the word "Factory" which was misspelled as "Feactory".
- Fixed the method name spelling from "Feactory" to "Factory"
- Updated all call sites that reference this method
- Ensured consistency across the telemetry logging extensions
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.Telemetry/Logging/LoggingEnrichmentExtensions.cs | Fixed typo in method name definition and updated three call sites |
| src/Libraries/Microsoft.Extensions.Telemetry/Buffering/GlobalBufferLoggingBuilderExtensions.cs | Updated call site to use corrected method name |
stephentoub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Microsoft Reviewers: Open in CodeFlow