Fix Winforms High DPI sample configuration #1495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We got pinged on the WebView2 repo about a bug in the HighDPI sample that was confusing our users: MicrosoftEdge/WebView2Feedback#1700 (comment) Here's the related issue on the dotnet/docs-desktop repo: dotnet#1485 The fix is to change the <compatibility> tag with the correct <configuration> tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We got pinged on the WebView2 repo about a bug in the HighDPI sample that was confusing our users:
MicrosoftEdge/WebView2Feedback#1700 (comment)
Here's the related issue on the dotnet/docs-desktop repo:
#1485
The fix is to change the tag with the correct tag. The correct tags are demonstrated on this page:
https://docs.microsoft.com/en-us/dotnet/framework/configure-apps/file-schema/winforms/
Fixes #1485