This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add cgroup v2 support to Interop.cgroups #39686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omajid
commented
Jul 23, 2019
omajid
commented
Jul 23, 2019
omajid
commented
Jul 23, 2019
omajid
commented
Jul 23, 2019
omajid
commented
Jul 23, 2019
src/System.Runtime.InteropServices.RuntimeInformation/tests/DescriptionNameTests.cs
Show resolved
Hide resolved
omajid
changed the title
omajid
commented
Jul 23, 2019
bartonjs
reviewed
Jul 24, 2019
bartonjs
reviewed
Jul 24, 2019
bartonjs
reviewed
Jul 24, 2019
omajid
force-pushed
the
cgroupv2
branch
2 times, most recently
from
ecd3961 to
b5cadcf
Compare
Member
Author
|
cc @tmds |
Member
|
cc @janvorli |
omajid
commented
Jul 30, 2019
omajid
force-pushed
the
cgroupv2
branch
2 times, most recently
from
af310f9 to
15e99a0
Compare
stephentoub
reviewed
Oct 19, 2019
stephentoub
reviewed
Oct 23, 2019
stephentoub
reviewed
Oct 23, 2019
stephentoub
reviewed
Oct 23, 2019
stephentoub
reviewed
Oct 23, 2019
Member
stephentoub
left a comment
stephentoub
left a comment
There was a problem hiding this comment.
A few more comments, but generally looks good.
Member
Author
|
@stephentoub Thanks for the review and your great suggestions! Does the updated patch look okay now? |
Fix up code to adjust cgroup v1 assumptions and check cgroup v2 paths, locations and values. Continue using the older cgroup v1 terminology for APIs.
stephentoub
approved these changes
Oct 24, 2019
Member
|
LGTM. Thanks. I pushed a commit to clean up the tests a bit, in particular to use our FileCleanupTestBase helper rather than generating random file names and tracking deleting them. |
Member
Author
Thanks, that's very kind of you! |
Member
|
The related PR in coreclr is needed to make the runtime/GC aware of cgroup v2: dotnet/coreclr#25906. |
This was referenced Jan 31, 2020
omajid
added a commit
to omajid/dotnet-corefx
that referenced
this pull request
Feb 11, 2020
* Add cgroup v2 support to Interop.cgroups Fix up code to adjust cgroup v1 assumptions and check cgroup v2 paths, locations and values. Continue using the older cgroup v1 terminology for APIs. * Clean up new tests
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Add cgroup v2 support to Interop.cgroups Fix up code to adjust cgroup v1 assumptions and check cgroup v2 paths, locations and values. Continue using the older cgroup v1 terminology for APIs. * Clean up new tests Commit migrated from dotnet/corefx@8d18e3c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up code to adjust cgroup v1 assumptions and check cgroup v2 paths, locations and values.
Continue using the older cgroup v1 terminology for APIs.