This repository was archived by the owner on Jan 23, 2023. It is now read-only.
[Revived PR] Faster Buffer.MemoryCopy for AMD64#9143
Closed
jamesqo wants to merge 3 commits intodotnet:masterfrom
Closed
[Revived PR] Faster Buffer.MemoryCopy for AMD64#9143jamesqo wants to merge 3 commits intodotnet:masterfrom
jamesqo wants to merge 3 commits intodotnet:masterfrom
Conversation
Author
|
Again this is largely a cleaned-up version of the same code I had written earlier, but I'll post benchmarks regardless. I have to re-build CoreCLR and write the benchmarks however, so I won't be able to do so straightaway. I'll update this PR when I have them. |
Member
|
What's the impact with #7198 ? Does it replace the pinvoke as suggested? (Would be in Win x64 only though) |
Merged
Author
|
Going to get back to this sometime later-- have been busy lately |
Member
|
Superseded by #9786 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revival of the PR at #6638 I had to close a few months earlier because it had too many comments. I basically re-wrote the code I had written earlier, except with a few changes:
Please note: I am looking to get this merged mostly as-is because it's a clear win over what we currently have. Once this gets in, then we can open the door for further discussion/experimentation/etc. over optimizations.
/cc @jkotas, @nietras @tannergooding @benaadams FYI