Move SB metadata to intermediates#53749
Merged
wtgodbe merged 9 commits intodotnet:mainfrom Feb 9, 2024
Merged
Conversation
ghost
added
area-infrastructure
|
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
wtgodbe
approved these changes
Feb 1, 2024
eng/Version.Details.xml
Outdated
| <SourceBuild RepoName="roslyn" ManagedOnly="true" /> | ||
| </Dependency> | ||
| <!-- Intermediate is necessary for source build. --> | ||
| <Dependency Name="Microsoft.SourceBuild.Intermediate.runtime.linux-x64" Version="9.0.0-preview.2.24080.11"> |
Member
There was a problem hiding this comment.
I personally find it more useful to group the dependencies by Repo. Do others have an opinion?
Member
Author
There was a problem hiding this comment.
I agree with this. I've re-arranged the intermediates in 8de9914
ellahathaway
force-pushed
the
sb-metadata
branch
from
ad536b2 to
2cd4a73
Compare
ellahathaway
force-pushed
the
sb-metadata
branch
from
86f807f to
e2e623b
Compare
wtgodbe
approved these changes
Feb 6, 2024
onurmicoogullari
pushed a commit
to onurmicoogullari/aspnetcore
that referenced
this pull request
Feb 14, 2024
* Move SB metadata to intermediates * arrange intermediates with deps from same repo * nit * Update Versions.props
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes in this pull request aim to improve the UX and guideance around the SourceBuild metadata by placing the metadata on explicit source-build intermediates.
The changes include:
Related to dotnet/source-build#3373 and dotnet/source-build#4073