Fix existing resources with the azure publisher#8622
Merged
Conversation
- Added existing resources to baseline tests
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
tests/Aspire.Hosting.Azure.Tests/AzurePublisherTests.cs:46
- [nitpick] Consider extracting the hard-coded resource group 'rg-shared' into a constant or variable to avoid duplication and improve maintainability.
builder.AddAzureStorage("existing-storage").PublishAsExisting("images", "rg-shared");
src/Aspire.Hosting.Azure/AzurePublishingContext.cs:196
- Verify that wrapping the parameter map value in a FunctionCallExpression maintains the intended behavior, as this change alters how the resource group is referenced.
ParameterResource p => new FunctionCallExpression(new IdentifierExpression("resourceGroup"), parameterMap[p].Value.Compile()),
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ExistingAzureResourceAnnotationwhen looking for parameters.Fixes #8619
Checklist