Merged
Conversation
davidfowl
reviewed
Feb 15, 2025
eerhardt
reviewed
Feb 18, 2025
danmoseley
reviewed
Feb 19, 2025
eerhardt
approved these changes
Feb 19, 2025
Member
eerhardt
left a comment
There was a problem hiding this comment.
This is looking nice now. Looks good. I just had a few minor comments to clean up.
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
Member
|
Can we get this into 9.1 build tonight..? |
Member
Author
|
/backport to release/9.1 |
Contributor
|
Started backporting to release/9.1: https://github.com/dotnet/aspire/actions/runs/13423606060 |
Member
|
Merging. The dotnet.aspire check seems to be stuck, but it passed on the backport, so assuming it is fine. All other builds/tests passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reacting to https://github.com/dotnet/aspire/pull/7374/files#r1950365868
IAspireStoreby moving one method to extensionsIAspireStorefrom DIChecklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):