You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Mpdreamz does this change make sense? The PingRequest uses "ping" as the OperationName, I assume the otel part of ES is doing this projection to DisplayName?
@sebastienros I'm going to check this on our end. I expected both DisplayName and OperationName to match and be "ping", so there may be a bug in a recent refactoring of the OTel instrumentation in our libraries.
@sebastienros - Having reviewed our changes, I see that this is expected, and this PR LGTM.
Our Transport layer creates a general Activity passing in the HTTP method name, which becomes OperationName and DisplayName (HEAD in this case). We provide a callback to our client library built on top of Transport, which then sets the DisplayName to the logical operation name (ping in this case). As there is no API to change OperationName, we leave that as is. Since OTLP exports using the DisplayName, this is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
needs-area-labelAn area label is needed to ensure this gets routed to the appropriate area owners
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7452
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):