[main] Update dependencies from microsoft/usvc-apiserver

[dotnet-maestro]

This pull request updates the following dependencies

From https://github.com/microsoft/usvc-apiserver

• Subscription: 852f69a6-643d-499a-6cb6-08dbca4ebb98
• Build: 0.8.13
• Date Produced: October 30, 2024 6:16:27 PM UTC
• Commit: 9582c787e7963a2acf11111e5bc5a4938e7fe3ab
• Branch: refs/tags/v0.8.13

• Updates:
  • Microsoft.DeveloperControlPlane.darwin-amd64: from 0.8.11 to 0.8.13
  • Microsoft.DeveloperControlPlane.darwin-arm64: from 0.8.11 to 0.8.13
  • Microsoft.DeveloperControlPlane.linux-amd64: from 0.8.11 to 0.8.13
  • Microsoft.DeveloperControlPlane.linux-arm64: from 0.8.11 to 0.8.13
  • Microsoft.DeveloperControlPlane.windows-386: from 0.8.11 to 0.8.13
  • Microsoft.DeveloperControlPlane.windows-amd64: from 0.8.11 to 0.8.13
  • Microsoft.DeveloperControlPlane.windows-arm64: from 0.8.11 to 0.8.13

Microsoft Reviewers: Open in CodeFlow

[DamianEdwards]

@karolz-ms @eerhardt @davidfowl is this failure deliberately failing the run if any instances of dotnet-tests, dcp, or dcpctrl are found? It seems to be getting a hit on dotnet itself and forcing a non-zero exit?

[davidfowl]

cc @radical

[eerhardt]

@karolz-ms @eerhardt @davidfowl is this failure deliberately failing the run if any instances of dotnet-tests, dcp, or dcpctrl are found? It seems to be getting a hit on dotnet itself and forcing a non-zero exit?

I don't htink it is purposefully failing the build. It looks like it is just trying to clean up hanging processes:

aspire/tests/helix/send-to-helix-inner.proj

Lines 61 to 62 in 13bcaa0

	<_CleanupProcessesCommand Condition="'$(OS)' == 'Windows_NT'">powershell -ExecutionPolicy ByPass -NoProfile -command "&amp; get-ciminstance win32_process | where-object ExecutablePath -Match 'dotnet-tests|dcp.exe|dcpctrl.exe' | foreach-object { echo $_.ProcessId $_.ExecutablePath %3B stop-process -id $_.ProcessId -force -ErrorAction SilentlyContinue }"</_CleanupProcessesCommand>
	<_CleanupProcessesCommand Condition="'$(OS)' != 'Windows_NT'">pgrep -lf "dotnet-tests|dcp.exe|dcpctrl.exe" | awk '{print %3B system("kill -9 "$1)}'</_CleanupProcessesCommand>

I'm not sure what is returning 1....

[DamianEdwards]

I'm not sure what is returning 1....

We seem to have lots of exit 1 calls in eng/build.sh

[karolz-ms]

If you look at the logs (towards the end) https://helix.dot.net/api/2019-06-17/jobs/b3620043-5064-421c-b2af-da5741da835f/workitems/Aspire.Playground.Tests/console it seems like the test passed, but then the cleanup failed with code 1 ?

[DamianEdwards]

If you look at the logs (towards the end) https://helix.dot.net/api/2019-06-17/jobs/b3620043-5064-421c-b2af-da5741da835f/workitems/Aspire.Playground.Tests/console it seems like the test passed, but then the cleanup failed with code 1 ?

Right, exactly. Trying to figure out what caused it to exit 1.

[DamianEdwards]

Something seems to be printing a list of dotnet processes immediately beforehand

[radical]

That exit 1 is because the tests run actually got aborted:

Aborting test run: test run timeout of 1200000 milliseconds exceeded.
Results File: /datadisks/disk1/work/9C3608FE/w/ACF008F5/uploads/logs/TestResults.trx

Passed!  - Failed:     0, Passed:    16, Skipped:     0, Total:    16, Duration: 17 m 51 s - Aspire.Playground.Tests.dll (net8.0)
Test Run Aborted.

Code coverage results: /datadisks/disk1/work/9C3608FE/w/ACF008F5/uploads/logs/Aspire.Playground.Tests.cobertura.xml.
+ export _commandExitCode=1

And the last line above sets _commandExitCode=1 because of the tests being aborted, and that is the final exit code returned.

[DamianEdwards]

@radical aha! Seems we just weren't reading the log file hard enough 😄

So this was a typical timeout then? Just re-run and hope for the best?

[radical]

The playground tests passed on this run. I'll open a separate PR to improve the test output that we get. This regressed for us when we switched to the newer msbuild.

[karolz-ms]

/backport to release/9.0

[github-actions]

Started backporting to release/9.0: https://github.com/dotnet/aspire/actions/runs/11616480268