[release/8.2] Update dependencies#6377
Merged
joperezr merged 14 commits intodotnet:release/8.2from Oct 20, 2024
Merged
Conversation
eerhardt
reviewed
Oct 18, 2024
eerhardt
reviewed
Oct 18, 2024
eerhardt
reviewed
Oct 18, 2024
This reverts commit 76ce2dd.
Contributes to dotnet#6380
eerhardt
reviewed
Oct 18, 2024
| if (!string.IsNullOrEmpty(settings.Key)) | ||
| { | ||
| var credential = new AzureKeyCredential(settings.Key); | ||
| var credential = new ApiKeyCredential(settings.Key); |
Member
There was a problem hiding this comment.
This is working around a binary breaking change between beta versions of System.ClientModel 1.1.0. See Azure/azure-sdk-for-net#45554. The Azure.AI.OpenAI 2.0.0-beta5 version we are using was using that implicit operator, which is no longer there in the released 1.1.0 GA version. Using the ApiKeyCredential directly side-steps the implicit operator break.
eerhardt
approved these changes
Oct 18, 2024
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Hopefully CI passes someday.
Member
|
@joperezr - looks like this needs 2 approvals. |
Member
Author
|
Thanks for the help pushing this through |
joperezr
added a commit
to joperezr/aspire
that referenced
this pull request
Nov 13, 2024
…/9.0 #### AI description (iteration 1) #### PR Classification Code cleanup and dependency updates. #### PR Summary This pull request merges changes from `release/9.0` into `internal/release/9.0`, addressing several work items related to security, dependency updates, and code cleanup. - Removed `MilvusClient` creation logic and health checks from `src/Aspire.Hosting.Milvus/MilvusBuilderExtensions.cs`. - Updated various package dependencies in `Directory.Packages.props` and `eng/Version.Details.xml`. - Added `AssemblyInfo.cs` to `src/Aspire.Hosting.Python` to mark it as experimental. - Updated container image tags in `src/Aspire.Hosting.Milvus`, `src/Aspire.Hosting.MySql`, `src/Aspire.Hosting.Elasticsearch`, and `src/Aspire.Hosting.Keycloak`. - Removed deprecated package references and suppressed final package version in `src/Aspire.Hosting.Milvus/Aspire.Hosting.Milvus.csproj`. Related work items: dotnet#5994, dotnet#6054, dotnet#6298, dotnet#6377, dotnet#6417, dotnet#6435, dotnet#6451, dotnet#6460, dotnet#6498
github-actions
bot
added
the
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating NuGet and docker dependencies to latest.
Microsoft Reviewers: Open in CodeFlow