Skip to content

Conversation

@sr093906
Copy link
Contributor

No description provided.

@sr093906
Copy link
Contributor Author

@dotnet-policy-service agree

@tom-englert
Copy link
Collaborator

There are 8 commits, changing, removing and re-adding a lot of stuff, but finally it adds just two strings.
Can you squash that into one commit, please.

@sr093906
Copy link
Contributor Author

sr093906 commented Oct 22, 2025

Some elaborations of the snafu.

I initially searched "Resources.zh-Hans.resx" in the repo and found someone submitted a pull request in 2018. I was happy, thinking it is an easy task for me to update the translation.

But the fact is there are actually six places to check for.

So, I opened all the six discrete directories, downloaded 12 files ( "Resources.zh-Hans.resx" and "Resources.resx" ) one by one, and used ResXResourceManager to localize them. The result is not bad. Only two of them needs updating: the one in https://github.com/dotnet/ResXResourceManager/tree/master/src/ResXManager.Translators/Properties and the one in https://github.com/dotnet/ResXResourceManager/tree/master/src/ResXManager.View/Properties.

Why do I only update the latter? Because I skimmed the strings in "ResXManager.Translators/Properties" and just found they are related to AI translation. I am not a fan of that. So, only two strings in one file was updated at last.

Sorry for so many commits but so small contribution. If you permit, I will close the issue and re-fork the repo to update only one file. I don't know how to squash multiple commits into one via web interface.

@tom-englert
Copy link
Collaborator

OK, if that's intended I can squash it during the merge.

@tom-englert tom-englert merged commit 42cbdbd into dotnet:master Oct 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants