removed translation feature

[bidi47]

No description provided.

[github-actions]

Qodana for PHP

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Detected 101 dependencies

Third-party software list

This page lists the third-party software dependencies used in project

Dependency	Version	Licenses
brick/math	0.12.1	MIT
brick/varexporter	0.4.0	MIT
doctrine/collections	2.2.2	MIT
doctrine/common	3.4.4	MIT
doctrine/data-fixtures	1.7.0	MIT
doctrine/dbal	4.1.0	MIT
doctrine/deprecations	1.1.3	MIT
doctrine/event-manager	2.0.1	MIT
doctrine/inflector	2.0.10	MIT
doctrine/instantiator	2.0.0	MIT
doctrine/lexer	3.0.1	MIT
doctrine/migrations	3.8.0	MIT
doctrine/orm	3.2.1	MIT
doctrine/persistence	3.3.3	MIT
dotkernel/dot-authentication	2.4.0	MIT
dotkernel/dot-authorization	3.5.1	MIT
dotkernel/dot-controller	3.5.1	MIT
dotkernel/dot-data-fixtures	1.2.3	MIT
dotkernel/dot-dependency-injection	1.0.0	MIT
dotkernel/dot-errorhandler	3.4.1	MIT
dotkernel/dot-event	3.4.2	MIT
dotkernel/dot-flashmessenger	3.5.0	MIT
dotkernel/dot-helpers	3.5.1	MIT
dotkernel/dot-log	3.5.3	MIT
dotkernel/dot-mail	4.2.2	MIT
dotkernel/dot-navigation	3.5.1	MIT
dotkernel/dot-rbac-guard	3.5.0	MIT
dotkernel/dot-rbac	3.6.0	MIT
dotkernel/dot-response-header	3.3.1	MIT
dotkernel/dot-session	5.6.0	MIT
dotkernel/dot-twigrenderer	3.5.1	MIT
fig/http-message-util	1.1.5	MIT
friendsofphp/proxy-manager-lts	v1.0.18	MIT
laminas/laminas-authentication	2.16.0	BSD-3-Clause
laminas/laminas-code	4.14.0	BSD-3-Clause
laminas/laminas-component-installer	3.4.0	BSD-3-Clause
laminas/laminas-config-aggregator	1.15.0	BSD-3-Clause
laminas/laminas-diactoros	3.3.1	BSD-3-Clause
laminas/laminas-escaper	2.13.0	BSD-3-Clause
laminas/laminas-eventmanager	3.13.1	BSD-3-Clause
laminas/laminas-filter	2.37.0	BSD-3-Clause
laminas/laminas-form	3.20.0	BSD-3-Clause
laminas/laminas-httphandlerrunner	2.10.0	BSD-3-Clause
laminas/laminas-hydrator	4.15.0	BSD-3-Clause
laminas/laminas-i18n	2.28.0	BSD-3-Clause
laminas/laminas-inputfilter	2.30.1	BSD-3-Clause
laminas/laminas-json	3.6.0	BSD-3-Clause
laminas/laminas-loader	2.10.0	BSD-3-Clause
laminas/laminas-log	2.17.0	BSD-3-Clause
laminas/laminas-mail	2.25.1	BSD-3-Clause
laminas/laminas-mime	2.12.0	BSD-3-Clause
laminas/laminas-permissions-rbac	3.6.0	BSD-3-Clause
laminas/laminas-servicemanager	3.22.1	BSD-3-Clause
laminas/laminas-session	2.21.0	BSD-3-Clause
laminas/laminas-stdlib	3.19.0	BSD-3-Clause
laminas/laminas-stratigility	3.12.0	BSD-3-Clause
laminas/laminas-translator	1.0.0	BSD-3-Clause
laminas/laminas-validator	2.64.1	BSD-3-Clause
laminas/laminas-view	2.35.0	BSD-3-Clause
mezzio/mezzio-authentication	1.9.0	BSD-3-Clause
mezzio/mezzio-authorization-rbac	1.7.0	BSD-3-Clause
mezzio/mezzio-authorization	1.9.0	BSD-3-Clause
mezzio/mezzio-cors	1.12.1	BSD-3-Clause
mezzio/mezzio-fastroute	3.11.0	BSD-3-Clause
mezzio/mezzio-helpers	5.16.0	BSD-3-Clause
mezzio/mezzio-router	3.17.0	BSD-3-Clause
mezzio/mezzio-template	2.10.0	BSD-3-Clause
mezzio/mezzio-twigrenderer	2.15.0	BSD-3-Clause
mezzio/mezzio	3.19.1	BSD-3-Clause
nikic/fast-route	v1.3.0	BSD-3-Clause
nikic/php-parser	v4.19.1	BSD-3-Clause
psr/cache	3.0.0	MIT
psr/container	1.1.2	MIT
psr/http-client	1.0.3	MIT
psr/http-factory	1.1.0	MIT
psr/http-message	2.0	MIT
psr/http-server-handler	1.0.2	MIT
psr/http-server-middleware	1.0.2	MIT
psr/log	1.1.4	MIT
ramsey/collection	2.0.0	MIT
ramsey/uuid-doctrine	2.1.0	MIT
ramsey/uuid	4.7.6	MIT
roave/psr-container-doctrine	5.2.2	BSD-2-Clause
symfony/console	v7.1.3	MIT
symfony/deprecation-contracts	v3.5.0	MIT
symfony/filesystem	v7.1.2	MIT
symfony/polyfill-ctype	v1.30.0	MIT
symfony/polyfill-intl-grapheme	v1.30.0	MIT
symfony/polyfill-intl-idn	v1.30.0	MIT
symfony/polyfill-intl-normalizer	v1.30.0	MIT
symfony/polyfill-mbstring	v1.30.0	MIT
symfony/polyfill-php72	v1.30.0	MIT
symfony/polyfill-php80	v1.30.0	MIT
symfony/polyfill-php81	v1.30.0	MIT
symfony/service-contracts	v3.5.0	MIT
symfony/stopwatch	v7.1.1	MIT
symfony/string	v7.1.3	MIT
symfony/var-exporter	v7.1.2	MIT
twig/twig	v3.11.0	BSD-3-Clause
webimpress/safe-writer	2.2.0	BSD-2-Clause
webmozart/assert	1.11.0	MIT

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[alexmerlin]

There are some language/translation related relics left that need to be removed:

• https://github.com/dotkernel/frontend/blob/issue-445/src/App/templates/layout/default.html.twig#L2: replace variable {{ language_key }} with string en
• https://github.com/dotkernel/frontend/blob/issue-445/src/App/templates/layout/default.html.twig#L8: replace V3 with V5 (not related to this, but should be fixed)
• Delete file https://github.com/dotkernel/frontend/blob/issue-445/src/App/assets/scss/components/_language.scss
• Delete line https://github.com/dotkernel/frontend/blob/issue-445/src/App/assets/scss/index.scss#L13
• Delete line https://github.com/dotkernel/frontend/blob/issue-445/src/App/src/ConfigProvider.php#L74 then adjust the number of spaces before the arrows
• Delete line https://github.com/dotkernel/frontend/blob/issue-445/test/Unit/App/ConfigProviderTest.php#L77

Finally, rebuild app.js and app.css.

[bidi47]

the changes are done - i asked for another review

i must have made the js updates right as you were reviewing because they were already done
there were no other edits to app.js and app.css after i implemented your changes

[alexmerlin]

Let's try again:

• Delete file https://github.com/dotkernel/frontend/blob/issue-445/src/App/assets/scss/components/_language.scss
• Delete line https://github.com/dotkernel/frontend/blob/issue-445/src/App/assets/scss/index.scss#L13

Finally, rebuild app.js and app.css.

[bidi47]

Let's try again:

* Delete file https://github.com/dotkernel/frontend/blob/issue-445/src/App/assets/scss/components/_language.scss

* Delete line https://github.com/dotkernel/frontend/blob/issue-445/src/App/assets/scss/index.scss#L13

Finally, rebuild app.js and app.css.

oops, my bad
i read those assets as 'js' instead of 'scss' because they're so similar :)