Allow route name placeholders #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
arhimede
reviewed
Oct 17, 2025
Member
arhimede
left a comment
arhimede
left a comment
There was a problem hiding this comment.
an you add some tests ?
especially for the case when there is a collision of routes , to be clear the precedence
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
alexmerlin
approved these changes
Oct 21, 2025
Jurj-Bogdan
pushed a commit
to Jurj-Bogdan/dot-rbac-guard
that referenced
this pull request
Oct 22, 2025
Allow route name placeholders
Jurj-Bogdan
pushed a commit
to Jurj-Bogdan/dot-rbac-guard
that referenced
this pull request
Nov 7, 2025
Allow route name placeholders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #42 and expanded to all available
Guardclasses.As discussed,
*can be used as a placeholder for route names and will be replaced where found in such a way aspreg_matchshould correctly select a requested route against the placeholder routes from the config.Tested on a fresh
dotkernel/adminproject, but let me know if i've missed anything that might cause issues in more complex applications.