Skip to content

Conversation

@Jurj-Bogdan
Copy link
Member

#67

Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
@Jurj-Bogdan Jurj-Bogdan linked an issue Feb 6, 2025 that may be closed by this pull request
@Jurj-Bogdan Jurj-Bogdan added this to the 5.0 milestone Feb 6, 2025
@Jurj-Bogdan Jurj-Bogdan added the 5.0 label Feb 6, 2025
@arhimede
Copy link
Member

arhimede commented Feb 6, 2025

@alexmerlin why we created the branch 4.1 and not branch 5 ?

@alexmerlin
Copy link
Member

@alexmerlin why we created the branch 4.1 and not branch 5 ?

@arhimede When we removed laminas-log, we created branch 4.0.

Next, we upgraded laminas-servicemanager to 4.x (which introduced a BC break).
This would have required another major release but it was too soon to jump from 4.0 directly to 5.0.

So, we introduced an intermediary 4.1 "hack" both in dot-log and dot-errorhandler.
The hack makes:

  • dot-errorhandler <4.1 compatible with dot-log <4.1
  • dot-errorhandler >=4.1 compatible with dot-log >=4.1

See your comment:

No need for version 5, we can merge in 4

Maybe you still have a tab somewhere in Notepad explaining us this idea a couple of days ago...

Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
@arhimede arhimede changed the base branch from 4.1 to 5.0 February 10, 2025 10:45
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
@Jurj-Bogdan Jurj-Bogdan linked an issue Feb 11, 2025 that may be closed by this pull request
Signed-off-by: Jurj-Bogdan <bogdanjurj11@gmail.com>
@alexmerlin alexmerlin merged commit aaf3967 into dotkernel:5.0 Feb 14, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Log errors with placehoders Implement PSR 3

3 participants