Conversation
If we don't add those, we have to copy the libraries manually. Now with that, they are automatically added in the pygbx folder
Adding arguments to copy the lzo1x libraries
donadigo
requested changes
Jun 22, 2021
Owner
donadigo
left a comment
donadigo
left a comment
There was a problem hiding this comment.
I'm really not in favour of maintaining binary third party DLLs/so files. The LZO class itself is fine, but if anything, python-lzo should be fixed instead so that it works on Windows and Linux. The problem is that it requires liblzo to be installed which differs based on the OS (I believe).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove broken python-lzo library and replace it with custom LZO libs