Added ArrayCollection::createFrom.#91
Merged
Ocramius merged 2 commits intodoctrine:masterfrom Jul 15, 2016
Merged
Conversation
Member
|
From the IRC logs, here's the "why" behind this PR:
The issue is that We can't make The proper solution would be to implement |
131df33 to
d451640
Compare
Contributor
Author
|
@Ocramius Test added. I also got rid of that shitty bootstrap. |
Member
|
👍 thanks! |
This was referenced Feb 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows derived classes to specify how new instances should be created when constructor semantics have changed. Without this, derived classes that modify constructor semantics have to re-implement the four affected methods using copy and paste because all hard-coded calls to
new static($elements)are invalid.🔖 I would appreciate a new tag for this PR.