Conversation
Majkl578
approved these changes
Aug 29, 2017
phpcs.xml.dist
Outdated
| @@ -0,0 +1,22 @@ | |||
| <?xml version="1.0"?> | |||
| <ruleset name="Coding Standards for doctrine"> | |||
| <description>Coding Standards for doctrine.</description> | |||
Contributor
There was a problem hiding this comment.
This should probably be "Coding Standard for Doctrine Collections." (and same for ruleset name)
Member
Author
There was a problem hiding this comment.
You're right, I was too lazy to change it (and I probably didn't change on the other projects as well - shame on me!).
Member
Author
There was a problem hiding this comment.
I've just found out that the name attribute and the description element are useless here. So I'll just kill them
| colors="true" | ||
| verbose="true" | ||
| beStrictAboutOutputDuringTests="true" | ||
| beStrictAboutTestsThatDoNotTestAnything="true" |
Member
Author
There was a problem hiding this comment.
I've tried explained on the commit message (cb7f39d) but the reason is that we were just repeating the default configuration, which is kind of redundant.
Since they have the same value as the default.
Modifying things to use Travis-CI build stages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.