Support for azure/login@v2?

[andrasg]

Description

I am trying to push to an Azure Container Registry using azure/login@v2.

I have successfully setup federated workload identities auth using: Configure a federated identity credential on an app

      - name: Azure login
        uses: azure/login@v2
        with:
          client-id: ${{ secrets.AZURE_CLIENT_ID }}
          tenant-id: ${{ secrets.AZURE_TENANT_ID }}
          subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

The above task successfully authenticates to Azure. I am unsure though how docker/login-action@v3 would be able to pick up the authenticated context. Is this supported? If not, would be a great addition.

nb: auth to ACR using username+password works great:

      - name: 'Docker login'
        uses: docker/login-action@v3
        with:
          registry: ${{ secrets.ACR_REGISTRY }}
          username: ${{ secrets.ACR_USERNAME }}
          password: ${{ secrets.ACR_PASSWORD }}

[lgmorand]

@andrasg are you using docker credentials (or SPN) ?

with docker admin credentials, I get

unauthorized: Application not registered with AAD.

[BasJanssenQuadira]

I would be open to working on this issue as my first contribution (as I can use the feature in my own pipelines as well.) Would it be acceptable to implement it using the Azure CLI, similar to how azure/login@v2 does it?

[tiagonunes1491]

I was able to pull it off with a intermediate step to get the token. It's a work around.

  - name: Log in to Azure
    uses: azure/login@v2
    with:
      client-id: ${{ secrets.AZURE_CLIENT_ID }}
      tenant-id: ${{ secrets.AZURE_TENANT_ID }}
      subscription-id: ${{ secrets.AZURE_SUBSCRIPTION_ID }}

  - name: Get ACR access token
    id: acr_token
    run: |
      ACR_TOKEN=$(az acr login --name ${{ inputs.acr-name }} --expose-token --output tsv --query accessToken)
      echo "token=${ACR_TOKEN}" >> $GITHUB_OUTPUT

  - name: Log in to Docker with new token
    uses: docker/login-action@v3
    with:
      registry: ${{ inputs.acr-name }}.azurecr.io
      username: 00000000-0000-0000-0000-000000000000
      password: ${{ steps.acr_token.outputs.token }}