Skip to content

Conversation

@ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Dec 15, 2025

What I did

Watcher implementation is selected based on a build tag. This one used to be set by OS, but this brings a constraining requirement to use CGO for users of the compose SDK, even if they don't rely on this feature.
=> Switched to a specific build tag, set by makefile when running on MacOS
Also fixed GO_BUILDTAGS not being passed to bake

Related issue
closes #13448

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@ndeloof ndeloof requested a review from a team as a code owner December 15, 2025 07:56
@ndeloof ndeloof requested a review from glours December 15, 2025 07:56
@ndeloof ndeloof changed the title Introduced fsnotify build tag to select watcher implementation. Introduced a build tag to select watcher implementation. Dec 15, 2025
Copy link
Contributor

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours merged commit e224264 into docker:main Dec 15, 2025
24 checks passed
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 19, 2025
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [docker/compose](https://github.com/docker/compose) | patch | `v5.0.0` -> `v5.0.1` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>docker/compose (docker/compose)</summary>

### [`v5.0.1`](https://github.com/docker/compose/releases/tag/v5.0.1)

[Compare Source](docker/compose@v5.0.0...v5.0.1)

#### What's Changed

##### 🐛 Fixes

- Restored support for `COMPOSE_COMPATIBILITY` by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13424](docker/compose#13424)
- Fixed grammatical errors and improve clarity in code. by [@&#8203;xiaolinny](https://github.com/xiaolinny) in [#&#8203;13429](docker/compose#13429)
- Fixed broken `run --quiet`. by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13430](docker/compose#13430)
- Fixed SDK example by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13416](docker/compose#13416)
- Added a check buildx version is set before comparing it. by [@&#8203;yangfeiyu20102011](https://github.com/yangfeiyu20102011) in [#&#8203;13415](docker/compose#13415)
- Fixed grammar: pluralize 'service' and remove apostrophes in lets. by [@&#8203;rashmivagha](https://github.com/rashmivagha) in [#&#8203;13423](docker/compose#13423)
- Fixed progress UI not restoring terminal once operation completes. by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13439](docker/compose#13439)
- Fixed status alignment in progress UI. by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13438](docker/compose#13438)
- Restored image layer download progress details on pull. by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13445](docker/compose#13445)
- Added 'configured' event at the end of model configuration phase. by [@&#8203;glours](https://github.com/glours) in [#&#8203;13446](docker/compose#13446)
- Introduced a build tag to select watcher implementation. by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13452](docker/compose#13452)
- Removed mention for `v2` on README. by [@&#8203;alexislefebvre](https://github.com/alexislefebvre) in [#&#8203;13451](docker/compose#13451)
- Fixed missing error handling in `setEnvWithDotEnv`. by [@&#8203;htoyoda18](https://github.com/htoyoda18) in [#&#8203;13450](docker/compose#13450)
- Adopted morikuni/aec library over raw ANSI sequences. by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13440](docker/compose#13440)
- Prevented incorrect progress metrics to break compose display. by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13457](docker/compose#13457)
- Restored support for BUILDKIT\_PROGRESS. by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13455](docker/compose#13455)
- Added check model plugin is successfully loaded. by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13464](docker/compose#13464)
- Added a warning when no service has been selected to build. by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13467](docker/compose#13467)

##### ⚙️ Dependencies

- Drop Go min patch version by [@&#8203;austinvazquez](https://github.com/austinvazquez) in [#&#8203;13418](docker/compose#13418)
- bump golang 1.24.11 by [@&#8203;austinvazquez](https://github.com/austinvazquez) in [#&#8203;13417](docker/compose#13417)
- bump osxcross by [@&#8203;ndeloof](https://github.com/ndeloof) in [#&#8203;13425](docker/compose#13425)
- bump golang.org/x/sys from 0.38.0 to 0.39.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13433](docker/compose#13433)
- bump github.com/docker/cli-docs-tool from 0.10.0 to 0.11.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13437](docker/compose#13437)
- bump golang.org/x/sync from 0.18.0 to 0.19.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13434](docker/compose#13434)
- bump tags.cncf.io/container-device-interface from 1.0.1 to 1.1.0 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13441](docker/compose#13441)
- bump github.com/moby/buildkit from 0.26.2 to 0.26.3 by [@&#8203;dependabot](https://github.com/dependabot)\[bot] in [#&#8203;13462](docker/compose#13462)

#### New Contributors

- [@&#8203;yangfeiyu20102011](https://github.com/yangfeiyu20102011) made their first contribution in [#&#8203;13415](docker/compose#13415)
- [@&#8203;xiaolinny](https://github.com/xiaolinny) made their first contribution in [#&#8203;13429](docker/compose#13429)
- [@&#8203;alexislefebvre](https://github.com/alexislefebvre) made their first contribution in [#&#8203;13451](docker/compose#13451)
- [@&#8203;htoyoda18](https://github.com/htoyoda18) made their first contribution in [#&#8203;13450](docker/compose#13450)

**Full Changelog**: <docker/compose@v5.0.0...v5.0.1>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi41OS4xIiwidXBkYXRlZEluVmVyIjoiNDIuNTkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SDK packaging: avoid forcing CGO on Darwin for watch-only functionality

2 participants