fix: add MarshalJSON/MarshalYAML methods to v2 RAGStrategyConfig #1171
+311
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The v2 RAGStrategyConfig type was missing marshal methods which caused data loss during round-trip serialization. This adds: - MarshalYAML for RAGStrategyConfig to flatten Params into parent level - MarshalJSON for RAGStrategyConfig for JSON serialization consistency - UnmarshalJSON for RAGStrategyConfig to capture extra fields into Params - buildFlattenedMap helper for consistent marshal format - MarshalYAML/MarshalJSON/UnmarshalJSON for RAGDatabaseConfig These methods ensure that strategy-specific parameters stored in the Params map are properly flattened during marshaling and captured during unmarshaling, matching the behavior of the latest config version. Fixes docker#1084 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: majiayu000 <1835304752@qq.com>
Member
|
@majiayu000 the linter is not happy :-) |
Replace require.Equal with require.InEpsilon for floating-point comparisons to satisfy the testifylint linter rule. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #1084
Changes
MarshalJSON()method toRAGStrategyConfigto preserve data during JSON serializationMarshalYAML()method toRAGStrategyConfigto preserve data during YAML serializationUnmarshalJSON()method toRAGStrategyConfigto properly parse flattened JSONbuildFlattenedMap()helper function shared by both marshal methods for consistent output formatThe implementation ensures that strategy-specific parameters stored in the
Paramsmap are flattened into the parent level during marshaling (matching the YAML format), preventing database field loss during round-trip serialization.🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com