Skip to content

Comments

Disable/move default webapps, per upstream recommendation#181

Merged
yosifkit merged 1 commit intodocker-library:masterfrom
infosiftr:webapps
Dec 31, 2019
Merged

Disable/move default webapps, per upstream recommendation#181
yosifkit merged 1 commit intodocker-library:masterfrom
infosiftr:webapps

Conversation

@tianon
Copy link
Member

@tianon tianon commented Dec 23, 2019

@tianon
Copy link
Member Author

tianon commented Dec 23, 2019

Note: if you are currently using any of these default webapps, this is a BREAKING CHANGE (intentionally).

They are still available within the image under webapps.dist and should be trivial to move/symlink/copy back into the webapps folder (which is why we're not removing them completely -- the space savings would only be ~7MB, which when compared with the hassle required to add these back, is considered worth it).

tianon added a commit to infosiftr/stackbrew that referenced this pull request Dec 30, 2019
Instead of relying on existing example applets (docker-library/tomcat#181), this loads a very simple `index.jsp` file into the Tomcat webapps and verifies that it gets executed correctly.
tianon added a commit to infosiftr/stackbrew that referenced this pull request Dec 30, 2019
Instead of relying on existing example applets (docker-library/tomcat#181), this loads a very simple `index.jsp` file into the Tomcat webapps and verifies that it gets executed correctly.
@tianon
Copy link
Member Author

tianon commented Dec 30, 2019

Thanks to docker-library/official-images#7217 this is now green. 👍

As an example of one easy way to restore some default example webapp (such as the manager applet):

FROM tomcat:9.0-jdk13-openjdk-oracle
RUN cp -avT $CATALINA_HOME/webapps.dist/manager $CATALINA_HOME/webapps/manager

A symlink would probably work as well, although that's untested.

@yosifkit yosifkit merged commit 151e932 into docker-library:master Dec 31, 2019
@yosifkit yosifkit deleted the webapps branch December 31, 2019 00:45
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Dec 31, 2019
Changes:

- docker-library/tomcat@151e932: Merge pull request docker-library/tomcat#181 from infosiftr/webapps
- docker-library/tomcat@807a2b4: Disable/move default webapps, per upstream recommendation
trulex added a commit to trulex/docker that referenced this pull request Jul 23, 2020
As of docker-library/tomcat#181, the upstream-provided (example) webapps are not enabled by default.
@tianon tianon mentioned this pull request Nov 24, 2020
@brontide
Copy link

For those looking to use the stock image and add manager back in you can do with with an altered entrypoint. Handy alternative to building a custom image just to have the manager.

services:
  tomcat:
    restart: unless-stopped
    image: tomcat:9
    volumes:
      - "./webapps:/usr/local/tomcat/webapps"
      - "./tomcat-users.xml:/usr/local/tomcat/conf/tomcat-users.xml"
    entrypoint: |
      bash -c 'cp -a webapps.dist/manager webapps/; exec catalina.sh run'

@sezayirdagtekin

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Please provide alpine variant without bundled webapps

4 participants