Refactor tests with data generator.#5439
Merged
trivialfis merged 3 commits intodmlc:masterfrom Mar 26, 2020
Merged
Conversation
RAMitchell
approved these changes
Mar 26, 2020
Member
RAMitchell
left a comment
RAMitchell
left a comment
There was a problem hiding this comment.
Nice, I was thinking the other day that this needed tidying up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #5389 .
Currently the generator replaces only the
CreateDMatrixfunction. But for longer term, we need to generate more data types as we are adding inplace operations (like the quantile dmatrix). As a bonus we don't need to handle pointer to shared pointer anymore.