[R-package] fixed uses of class()#5426
Merged
pommedeterresautee merged 1 commit intodmlc:masterfrom Mar 20, 2020
jameslamb:r/class
Merged
[R-package] fixed uses of class()#5426pommedeterresautee merged 1 commit intodmlc:masterfrom jameslamb:r/class
pommedeterresautee merged 1 commit intodmlc:masterfrom
jameslamb:r/class
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I'd like to propose a minor change in the R package. I found two passes where
typeof(x) == 'listortypeof(x) != 'list'is being used to check that something is a list.This check isn't totally safe, since
data.tableordata.frameobjects will pass this check.In this PR, I propose changing to a stricter check,
identical(class(x)) == 'list'.Thanks for your time and consideration!