- ranking metric acceleration on the gpu#5398
Merged
RAMitchell merged 21 commits intodmlc:masterfrom Mar 22, 2020
Merged
Conversation
Member
Codecov Report
@@ Coverage Diff @@
## master #5398 +/- ##
=======================================
Coverage 84.07% 84.07%
=======================================
Files 11 11
Lines 2411 2411
=======================================
Hits 2027 2027
Misses 384 384 Continue to review full report at Codecov.
|
- this will *significantly* help train non ranking datasets that uses the auc metric (which
i hear is quite popular!)
- i'll post the perf. numbers shortly
Contributor
Author
auc metric performance numberstest environment
test
results
|
This reverts commit a38e7bd.
RAMitchell
approved these changes
Mar 10, 2020
This reverts commit 6a85632.
Contributor
Author
|
@trivialfis i would appreciate your review when you get a chance. |
trivialfis
approved these changes
Mar 19, 2020
Member
trivialfis
left a comment
There was a problem hiding this comment.
LGTM! Sorry for the long wait. Previously I mentioned with @RAMitchell that maybe simple functions are more suitable for implementing the GPU metrics as I think the registry is just too tricky and unnecessary. But I won't block the PR for this as we can refactor them later when needed (like implementing other metrics).
…eve memory pressure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the last part of #5326 that has been split. the performance numbers are here
please note the following:
map,ndcg,preauc[pr]) applicable to ranking and non-ranking datasets work thusly:@RAMitchell @trivialfis - please review.