This repository was archived by the owner on Aug 11, 2020. It is now read-only.
Add except handling in TensorContainer#369
Merged
szha merged 1 commit intodmlc:masterfrom Mar 1, 2019
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In C++11, destructor is noexcept(true) in default, so noexcept(false) needs to be manually added in destructors to properly handle errors thrown in destruction, otherwise, std::terminate will be called leading to program crash.
In TensorContainer, error will be thrown in destruction according to the following codes:
mshadow/mshadow/tensor_container.h
Line 75 in 3dc8081
mshadow/mshadow/tensor_container.h
Line 182 in 3dc8081
This PR is created in addition to apache/mxnet#14223 in order to fully fix memory leaks in mxnet exit.