Skip to content

Change DPI to 96 #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlemstra merged 3 commits into from
Jan 10, 2025
Merged

Change DPI to 96 #1781

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2e936e
Change DPI to 96
Ruben2776 Jan 8, 2025
4ce9825
Update IMagickImageExtentions.cs
Ruben2776 Jan 9, 2025
65fcaed
Update IMagickImageExtentions.cs
Ruben2776 Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/Magick.NET.AvaloniaMediaImaging/IMagickImageExtentions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,34 @@ namespace ImageMagick;
public static partial class IMagickImageExtentions
{
/// <summary>
/// Converts this instance to a <see cref="WriteableBitmap"/>.
/// Converts this instance to a <see cref="WriteableBitmap"/> with a default DPI of 96x96.
/// </summary>
/// <param name="self">The image.</param>
/// <typeparam name="TQuantumType">The quantum type.</typeparam>
/// <returns>A <see cref="WriteableBitmap"/>.</returns>
public static unsafe WriteableBitmap ToWriteableBitmap<TQuantumType>(this IMagickImage<TQuantumType> self)
where TQuantumType : struct, IConvertible
{
Copy link
Owner

@dlemstra dlemstra Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would create a private method that has the current implementation and specify either new Vector(96, 96) or new Vector(self.Density.X, self.Density.Y) as an argument to that method.

Copy link
Contributor Author

@Ruben2776 Ruben2776 Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it with ToWriteableBitmapInternal and sending argument between the two.

return self.ToWriteableBitmapInternal(false);
}

/// <summary>
/// Converts this instance to a <see cref="WriteableBitmap"/>.
/// </summary>
/// <param name="self">The image.</param>
/// <typeparam name="TQuantumType">The quantum type.</typeparam>
/// <returns>A <see cref="WriteableBitmap"/>.</returns>
public static unsafe WriteableBitmap ToWriteableBitmapWithDensity<TQuantumType>(this IMagickImage<TQuantumType> self)
where TQuantumType : struct, IConvertible
{
return self.ToWriteableBitmapInternal(true);
}

private static unsafe WriteableBitmap ToWriteableBitmapInternal<TQuantumType>(this IMagickImage<TQuantumType> self, bool withDensity)
where TQuantumType : struct, IConvertible
{
var size = new PixelSize((int)self.Width, (int)self.Height);
var density = new Vector(self.Density.X, self.Density.Y);
var density = withDensity ? new Vector(self.Density.X, self.Density.Y) : new Vector(96, 96);
var bitmap = new WriteableBitmap(size, density, PixelFormats.Rgba8888, AlphaFormat.Unpremul);

using var framebuffer = bitmap.Lock();
Expand Down