fix: texture coord mask in triangle rendering#4533
Merged
Loobinex merged 2 commits intodkfans:masterfrom Feb 12, 2026
Merged
Conversation
… wrap in 32 row texture boundary.
There was a problem hiding this comment.
Pull request overview
This PR fixes a texture coordinate overflow issue in the trig_render_md05 triangle rendering function by constraining the high byte of texture coordinates to a 32-row boundary. The fix addresses rendering artifacts that occur when viewing textured objects at sharp angles while the player possesses a minion.
Changes:
- Modified texture coordinate mask from
0xFF(8 bits, 0-255) to0x1F(5 bits, 0-31) for the high byte (colH) in texture coordinate calculations - Applied the fix to both the negative and non-negative
point_xcode paths intrig_render_md05
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all texture coord cals… wrap in 32 row texture boundary.
The calculation to remap texture coords is exacerbated my looking at things with sharp angles, that are textured and while the player is in possession of a minion